Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate iOS test sheet #70
Merged
Conversation
|
LGTM+++ Great job |
wikitemplate-ios.md
Outdated
| - [ ] Make sure that data from the last version appears in the new version OK | ||
| - [ ] Test that the previous version's cookies are preserved in the next version | ||
| - [ ] Test that saved passwords are retained upon upgrade | ||
| - [ ] Ensure stats are retained when upgrading from previuos version |
This comment has been minimized.
This comment has been minimized.
| - [ ] Check that installer is close to the size of last release. | ||
| - [ ] Check the Brave version in About and make sure it is EXACTLY as expected. | ||
| - [ ] Check that installer is close to the size of last release | ||
| - [ ] Check the Brave version in About and make sure it is EXACTLY as expected | ||
|
|
||
| ## Data |
This comment has been minimized.
This comment has been minimized.
kjozwiak
May 24, 2018
Member
Probably should add "Shield" settings retention per site in there as well.
|
@srirambv everything looks good other than the small nit. We should probably add a case for testing shield setting retention per site as well. |
|
Updated the test to add shield settings in data section. Is that sufficient? |
wikitemplate-ios.md
Outdated
| @@ -9,7 +9,8 @@ | |||
| - [ ] Make sure that data from the last version appears in the new version OK | |||
| - [ ] Test that the previous version's cookies are preserved in the next version | |||
| - [ ] Test that saved passwords are retained upon upgrade | |||
| - [ ] Ensure stats are retained when upgrading from previuos version | |||
| - [ ] Ensure stats are retained when upgrading from previous version | |||
| - [ ] Ensure per site settings are retained when upgrading from preivous version | |||
This comment has been minimized.
This comment has been minimized.
|
@srirambv LGTM other then the |
|
@kjozwiak @LaurenWags fixed the nits and updated the history test. A quick scan and its ready to be merged |
|
LGTM other than the small nit mentioned. |
wikitemplate-ios.md
Outdated
| @@ -21,12 +24,18 @@ | |||
| - [ ] Test that you are able to delete a bookmark folder with bookmarks inside | |||
| - [ ] Test adding a bookmark domain subpaths is retained and you are successfully able to visit the domain subpath in a new tab | |||
|
|
|||
| ## Favouritesf | |||
This comment has been minimized.
This comment has been minimized.
|
Nailed the final nit. |
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
srirambv commentedMay 17, 2018
Fixes #59
Fixes #69