Skip to content

/ qa-resources

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tor tests #75

Merged
merged 4 commits into from Jul 18, 2018
Merged

Add Tor tests #75

merged 4 commits into from Jul 18, 2018

Conversation

@srirambv
Copy link
Contributor

srirambv commented Jul 9, 2018

Closes #74

  • Added Tor test section for regression checklist.
@srirambv
Add Tor tests
1883b76
@srirambv srirambv self-assigned this Jul 9, 2018
@srirambv srirambv requested review from kjozwiak and LaurenWags Jul 9, 2018
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
## Tor Tabs

- [ ] Visit check.torproject.org in a Tor private tab, ensure its shows success message for using a Tor exit node
- [ ] Disable Tor to switch to a private tab, visit check.torproject.org, ensure it shows failure message for not using Tor exit node

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

To confirm, for this one you mean Open Tor Private Tab, toggle the Tor switch off. Visit check.torproject.org and verify you are not using Tor.

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Updated the step
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated

- [ ] Visit check.torproject.org in a Tor private tab, ensure its shows success message for using a Tor exit node
- [ ] Disable Tor to switch to a private tab, visit check.torproject.org, ensure it shows failure message for not using Tor exit node
- [ ] Search check tor in a normal tab, Open the check.torproject.org link in a private tab, ensure tab uses Tor exit node

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

To confirm, for this one you mean Open a normal tab and search for Tor Check. Right click on check.torproject.org and select Open Link in New Private Tab with Tor. Ensure newly opened Private Tor tab uses a Tor exit node.

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Updated the step
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Disable Tor to switch to a private tab, visit check.torproject.org, ensure it shows failure message for not using Tor exit node
- [ ] Search check tor in a normal tab, Open the check.torproject.org link in a private tab, ensure tab uses Tor exit node
- [ ] Visit check.torproject.org in a tor private tab, note down exit node ip address, Click `New circuit for this site` in shields, ensure the exit node ip address changes after page is reloaded
- [ ] Visit https://protonirockerxow.onion/ in a Private tab with TOR enabled, ensure login page is shown

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

Probably want to change TOR to Tor for consistency.
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Visit check.torproject.org in a tor private tab, note down exit node ip address, Click `New circuit for this site` in shields, ensure the exit node ip address changes after page is reloaded
- [ ] Visit https://protonirockerxow.onion/ in a Private tab with TOR enabled, ensure login page is shown
- [ ] Open Tor tab and disable Tor, visit https://protonirockerxow.onion/ ensure website doesn't load
- [ ] Visit https://browserleaks.com/geo, ensure location isn't shown

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018 •
edited

Contributor

Should we also confirm that you are not prompted for your location? i.e. 'Visit https://browserleaks.com/geo in Tor Private Tab, ensure location isn't shown and you are not prompted to Allow/Deny location sharing' or something to that effect?

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Prompt would only be shown if the request is sent through. Since Tor tabs block the request there will not be a notification shown. Hence didn't add the notification part.

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 11, 2018

Contributor

++
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Visit https://protonirockerxow.onion/ in a Private tab with TOR enabled, ensure login page is shown
- [ ] Open Tor tab and disable Tor, visit https://protonirockerxow.onion/ ensure website doesn't load
- [ ] Visit https://browserleaks.com/geo, ensure location isn't shown
- [ ] Visit https://diafygi.github.io/webrtc-ips/ in a Tor private tab with block all fingerprinting, ensure local IP is not shown

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

I think this should work without 'block all fingerprinting' enabled (see brave/browser-laptop#13397).

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Its covered in the next checklist with disable shields as well
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Visit check.torproject.org in a Tor private tab, ensure its shows success message for using a Tor exit node
- [ ] Disable Tor to switch to a private tab, visit check.torproject.org, ensure it shows failure message for not using Tor exit node
- [ ] Search check tor in a normal tab, Open the check.torproject.org link in a private tab, ensure tab uses Tor exit node
- [ ] Visit check.torproject.org in a tor private tab, note down exit node ip address, Click `New circuit for this site` in shields, ensure the exit node ip address changes after page is reloaded

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

Change 'tor' to 'Tor' for consistency.
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Visit https://browserleaks.com/geo, ensure location isn't shown
- [ ] Visit https://diafygi.github.io/webrtc-ips/ in a Tor private tab with block all fingerprinting, ensure local IP is not shown
- [ ] Visit https://diafygi.github.io/webrtc-ips/ in a Tor private, disable shields, ensure WebRTC is blocked and no IP is shown
- [ ] Verify flash doesn't work on Tor private tabs even if it is enabled in about:preferences#plugins

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

Maybe also verify you are not prompted to allow Flash? i.e. 'Verify Flash does not work and you are not prompted to Allow/Deny Flash in a Tor Private Tab even if it is enabled in about:preferences#plugins'

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Same as before. Notification only shows up if the request goes through and since its blocked no notification will be shown
@LaurenWags
LaurenWags reviewed Jul 9, 2018
View changes
wikitemplate.md Outdated
- [ ] Visit https://diafygi.github.io/webrtc-ips/ in a Tor private, disable shields, ensure WebRTC is blocked and no IP is shown
- [ ] Verify flash doesn't work on Tor private tabs even if it is enabled in about:preferences#plugins
- [ ] Verify torrent viewer doesn't load in a Tor tab and warns when trying to load a torrent/magnet link in a Tor tab
- [ ] Verify Google Widevine doesn't load in Tor tabs

This comment has been minimized.

Sign in to view
Copy link
@LaurenWags

LaurenWags Jul 9, 2018

Contributor

Maybe also verify you are not prompted to install/run Widevine?

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 11, 2018

Author Contributor

Updated the step
@LaurenWags
Copy link
Contributor

LaurenWags commented Jul 9, 2018

Also general question - do we want to call them Tor Tabs (like the section header) or Tor Private Tabs (like in the individual cases)? Just thinking of consistency.
@srirambv
Fix review items
5d389c1
@srirambv
Copy link
Contributor Author

srirambv commented Jul 11, 2018

Addressed feedback and fixed typo's. Ready for review
@srirambv
Update private/tor shortcut
d4d50fc
@kjozwiak
kjozwiak requested changes Jul 18, 2018
View changes
Copy link
Member

kjozwiak left a comment

everything else looks good 👍
wikitemplate.md Outdated
- [ ] Visit https://check.torproject.org in a Tor private tab, note down exit node IP address, Click `New circuit for this site` in shields, ensure the exit node IP address changes after page is reloaded
- [ ] Visit https://protonirockerxow.onion/ in a Tor private tab, ensure login page is shown
- [ ] Open Tor private tab and toggle Tor switch, visit https://protonirockerxow.onion/ ensure website doesn't load
- [ ] Visit https://browserleaks.com/geo, ensure location isn't shown

This comment has been minimized.

Sign in to view
Copy link
@kjozwiak

kjozwiak Jul 18, 2018

Member

should add some more context here, should probably say Visit https://browserleaks.com/geo in a Tor private tab

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Jul 18, 2018

Author Contributor

fixed
@srirambv
Add context
fe34d17
@kjozwiak
kjozwiak approved these changes Jul 18, 2018
View changes
@kjozwiak
Copy link
Member

kjozwiak commented Jul 18, 2018

Thanks @srirambv, awesome work 👍 Everything LGTM! @LaurenWags really appreciate you going through the reviews as well!
@kjozwiak kjozwiak merged commit 03fb77a into brave:master Jul 18, 2018
@srirambv srirambv mentioned this pull request Jul 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags

@kjozwiak kjozwiak

Assignees

@srirambv srirambv

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@srirambv @LaurenWags @kjozwiak
You can’t perform that action at this time.