Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove obsolete FTP test #85
Merged
Conversation
|
LGTM++ We'll need to find an alternative for checking basic authentication. It originally regressed during a CR bump brave/browser-laptop#13883. The test site that I found was using FTP but we'll need to find something that's not using FTP. Created #86. |
|
|
|
Added HTTP Basic authentication test to fix #86 as well |
|
Just the small nits mentioned. I checked the URL against |
wikitemplate.md
Outdated
| - [ ] Test that WebSockets are working by ensuring http://slither.io/ runs once "Play" has been clicked. | ||
| - [ ] Visit https://www.httpwatch.com/httpgallery/authentication/#showExample10 and ensure "HTTP Basic Authenticaion" is working correctly when clicked on `Display Image` button. Follow the steps mentioned on page to verify it works correctly |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Aug 13, 2018
Member
small nits:
- "HTTP Basic Authenticaion" -> "HTTP Basic Authentication"
- is working correctly when clicking on the
Display Imagebutton. - Follow the steps mentioned on the page to verify it works correctly.
|
Fixed nits. Ready for review and merge. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
srirambv commentedAug 9, 2018
•
edited
Fixes #83
Fixes #86