Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test run generator for brave-core #94

Merged
merged 21 commits into from Nov 22, 2018
Merged

Conversation

@srirambv
Copy link
Contributor

srirambv commented Sep 11, 2018

Fixes #93

Milestones needs to organized on repo and that needs updating in future once we get to proper channel releases. This is only for temp changes to add issues with QA/Needed labels to test sheet.

@srirambv srirambv self-assigned this Sep 11, 2018
@srirambv srirambv requested a review from kjozwiak Sep 11, 2018
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
wikitemplate.md Show resolved Hide resolved
wikitemplate.md Outdated Show resolved Hide resolved
@kjozwiak
Copy link
Member

kjozwiak commented Nov 15, 2018

@srirambv there seems to be a bug here:

if('release-notes/include' in label_names or 'release-notes/exclude' in label_names and 'tests' not in label_names):
.

It also includes or 'release-notes/exclude' in label_names which will basically add anything that's labelled as 'release-notes/exclude' into release_notes.append(output_line).

Example with or 'release-notes/exclude' in label_names:

Create test runs for: 1

Generating Per-release checklist for 0.56.x - Release Hotfix 1 on all platforms
0.56.x - Release Hotfix 1
Release Notes
 - Cookies not imported - follow up to 1545.([#2013](https://github.com/brave/brave-browser/issues/2013))
 - Stats not imported during auto-upgrade.([#2014](https://github.com/brave/brave-browser/issues/2014))
 - Upgrade from Chromium 70.0.3538.77 to 70.0.3538.102.([#2099](https://github.com/brave/brave-browser/issues/2099))

Example without or 'release-notes/exclude' in label_names:

Create test runs for: 1

Generating Per-release checklist for 0.56.x - Release Hotfix 1 on all platforms
0.56.x - Release Hotfix 1
Release Notes
 - Upgrade from Chromium 70.0.3538.77 to 70.0.3538.102.([#2099](https://github.com/brave/brave-browser/issues/2099))
@kjozwiak
Copy link
Member

kjozwiak commented Nov 16, 2018

Generating an iOS run also generates the following:

Choose the platform for which you want to generate the test run: 3
Generating test runs for iOS  Sprint w/e 13th Jan 2019
['Sprint w/e 13th Jan 2019', 'Sprint w/e 16th Dec 2018', 'Sprint w/e 18th Nov 2018', 'Sprint w/e 2nd Dec 2018', 'Sprint w/e 30th Dec 2018', 'Sprint w/e 4th Nov 2018']
Release Note:

We can probably open a new issue to address the iOS issue as we need to get the scripts going for b-c since we'll be getting 0.56.x Hotfix 1 builds soon 👍

@srirambv
Copy link
Contributor Author

srirambv commented Nov 16, 2018

Fixed review comments for template and iOS. I'll do a follow up PR for the release notes. Will take it all out since Changelog generator is created for that now.

@kjozwiak kjozwiak merged commit f2e6ea9 into brave:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.