Skip to content

/ qa-resources

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mozilla Geolocation #96

Merged
merged 2 commits into from Sep 12, 2018
Merged

Fix Mozilla Geolocation #96

merged 2 commits into from Sep 12, 2018

Conversation

@srirambv
Copy link
Contributor

srirambv commented Sep 12, 2018

Fixes #95
@srirambv
Fix Mozilla Geolocation
629b093
@srirambv srirambv added the testsheet label Sep 12, 2018
@srirambv srirambv self-assigned this Sep 12, 2018
@srirambv srirambv requested a review from kjozwiak Sep 12, 2018
@kjozwiak
kjozwiak approved these changes Sep 12, 2018
View changes
Copy link
Member

kjozwiak left a comment

nit: just add shows the correct location and LGTM 👍
@srirambv
Fix nit
534131e
@kjozwiak
kjozwiak approved these changes Sep 12, 2018
View changes
Copy link
Member

kjozwiak left a comment

LGTM 👍 Thanks @srirambv!
@kjozwiak kjozwiak merged commit 3aa9915 into brave:master Sep 12, 2018
@srirambv srirambv deleted the srirambv:geo branch Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak

Assignees

@srirambv srirambv

Labels
testsheet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@srirambv @kjozwiak
You can’t perform that action at this time.