Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for vimeo playback issues brave/brave-browser#4770 #3
Conversation
|
@diracdeltas are you ok with these? |
|
lgtm if these work and fix the issue. @ryanbr can you please start a wiki doc in https://github.com/brave/referrer-whitelist/wiki documenting why each of these exceptions was added? i will add explanations for the ones i know about too. |
|
@ryanbr do you have a test plan we could use to verify this fix? for instance i tried going to https://ultimatecourses.com/learn/javascript-basics but that video shows up as not-playable either way. (it's only playable if you allow all cookies) |
| "https://cloud.typography.com/*" | ||
| "https://cloud.typography.com/*", | ||
| "https://*.vimeocdn.com/*", | ||
| "https://player.vimeo.com/*" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
was under the impression that it was a referral issue (which caused the cookie fault issue), and sure enough if I via scriptsafe extension, and only allow the above elements it should work. I'm open a better suggestion or fix. If its definitely not a referrer issue causing this, just close it. |
|
Sorry, still learning the ropes the systems. But here is a gif, of the fix in action; |
|
Is that okay @diracdeltas ? |
|
i must have tested something incorrectly before since https://ultimatecourses.com/learn/javascript-basics works now with this fix. @pilgrim-brave feel free to squash these commits and merge |
|
Everything is de-conflicted and merged. Testing locally to ensure I didn't break anything, then I'll run the Jenkins job to push the changes to production. |
ryanbr commentedJun 28, 2019
Allow vimeo to work on various sites.