Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for vimeo playback issues brave/brave-browser#4770 #3

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@ryanbr
Copy link
Collaborator

ryanbr commented Jun 28, 2019

Allow vimeo to work on various sites.

https://community.brave.com/t/vimeo-cookies-sorry-because-of-its-privacy-settings-this-video-cannot-be-played-here/61505/6
https://community.brave.com/t/not-able-to-view-vimeo-videos/48706
https://community.brave.com/t/vimeo-private-videos-not-showing/44325
@bbondy bbondy requested a review from diracdeltas Jun 28, 2019
@bbondy
Copy link
Member

bbondy commented Jun 28, 2019

@diracdeltas are you ok with these?

@diracdeltas
Copy link
Member

diracdeltas commented Jun 28, 2019

lgtm if these work and fix the issue. @ryanbr can you please start a wiki doc in https://github.com/brave/referrer-whitelist/wiki documenting why each of these exceptions was added? i will add explanations for the ones i know about too.

@diracdeltas
Copy link
Member

diracdeltas commented Jun 28, 2019

@ryanbr do you have a test plan we could use to verify this fix? for instance i tried going to https://ultimatecourses.com/learn/javascript-basics but that video shows up as not-playable either way. (it's only playable if you allow all cookies)

"https://cloud.typography.com/*"
"https://cloud.typography.com/*",
"https://*.vimeocdn.com/*",
"https://player.vimeo.com/*"

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Jun 28, 2019

Member

could you please indent using spaces instead of tabs here?

This comment has been minimized.

Copy link
@ryanbr

ryanbr Jun 28, 2019

Author Collaborator

sure. Done.

@ryanbr
Copy link
Collaborator Author

ryanbr commented Jun 28, 2019

was under the impression that it was a referral issue (which caused the cookie fault issue), and sure enough if I via scriptsafe extension, and only allow the above elements it should work. I'm open a better suggestion or fix.

If its definitely not a referrer issue causing this, just close it.

@ryanbr
Copy link
Collaborator Author

ryanbr commented Jul 2, 2019

Sorry, still learning the ropes the systems. But here is a gif, of the fix in action;
https://secure.fanboy.co.nz/gif/vimeo2.gif

@ryanbr
Copy link
Collaborator Author

ryanbr commented Jul 3, 2019

Is that okay @diracdeltas ?

Copy link
Member

diracdeltas left a comment

i must have tested something incorrectly before since https://ultimatecourses.com/learn/javascript-basics works now with this fix.

@pilgrim-brave feel free to squash these commits and merge

@pilgrim-brave pilgrim-brave merged commit fad6129 into brave:master Jul 8, 2019
@pilgrim-brave
Copy link
Collaborator

pilgrim-brave commented Jul 8, 2019

Everything is de-conflicted and merged. Testing locally to ensure I didn't break anything, then I'll run the Jenkins job to push the changes to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.