Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks are being sent to laptop when bookmark sync is off #110

Closed
LaurenWags opened this issue Jun 19, 2017 · 2 comments
Closed

Bookmarks are being sent to laptop when bookmark sync is off #110

LaurenWags opened this issue Jun 19, 2017 · 2 comments
Labels

Comments

@LaurenWags
Copy link

@LaurenWags LaurenWags commented Jun 19, 2017

Did you search for similar issues before submitting this one?
Yes

Description:
When part of a sync group and Bookmark sync is turned off (in Settings > Sync and toggle Bookmarks off (not 'Reset Sync')), device is sending and receiving bookmark updates.

Device Details:

Install Type(ARM, x86): ARM
Device(Phone, Tablet, Phablet): Galaxy S4
Android Version: 5.0.1
Brave Version:
1.0.23 beta

Steps to reproduce:

  1. Have an android that is actively part of a sync group with laptop.
  2. On android navigate to Settings > Sync and toggle Bookmarks off (do not 'Reset Sync').
  3. Add a bookmark.
  4. Bookmark is synced to laptop.

Actual Behavior
Bookmarks added while bookmark sync is off are added to the laptop

Expected Behavior
Expected bookmarks not to be added to the laptop.

Is this an issue with Beta build?
Yes

Is this an issue in the currently released version?
No

Can this issue be consistently reproduced?
Yes

Extra QA steps:
1.
2.
3.

Website problems only:

did you check with Brave Shields down?
did you check in Chrome for same behavior?
Screenshot if needed:

Any related issues:

@ayumi
Copy link
Contributor

@ayumi ayumi commented Jun 19, 2017

@SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jun 19, 2017

We decided to hide Bookmarks switch in the first version, because laptop doesn't handle updates as well, so we can close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.