Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual bookmarks not synced from laptop after Payments are switched off #121

Closed
LaurenWags opened this issue Jun 23, 2017 · 1 comment
Closed

Comments

@LaurenWags
Copy link

@LaurenWags LaurenWags commented Jun 23, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Toggling Payments on --> off appears to break sync.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    Brave 0.17.7
    rev 21cf3d1
    Muon 4.1.3

  • Steps to reproduce (two ways)
    One

    1. Switch payments on in Preferences. (I waited until my wallet was created)
    2. Switch payments off in Preferences.
    3. Set up folders and bookmarks on laptop.
    4. Set up folders and bookmarks on another device (I used Android and iOS).
    5. Set up sync group on laptop. Open sync background page.
    6. Join sync group on Android and iOS. All devices are synced as expected.
    7. I did an import, this also synced as expected.
    8. Add a bookmark on laptop to bookmarks bar.
    9. This bookmark does not get synced.

Two:

  1. Sync devices (ex. laptop and Android)
  2. Perform simple sync test (add bookmark to bookmarks bar on laptop), sync is working as expected.
  3. Switch on payments.
  4. Add bookmark to bookmarks bar on laptop. Sync is working as expected.
  5. Turn off payments.
  6. Again, add bookmark to bookmarks bar on laptop. This bookmark will not be synced.
  • Actual result:
    Bookmark added to bookmarks bar is not synced.

  • Expected result:
    Bookmark should be synced.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Add bookmark on Android. Bookmark is synced to laptop and iOS.
    2. Add bookmark on iOS. Bookmark is synced to laptop and Android.
  • Screenshot if needed:
    Covers steps 8 and 9 from the first scenario (it's a long recording)-
    111_01

  • Any related issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.