Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show version of brave/sync in about:brave #128

Closed
diracdeltas opened this issue Jul 10, 2017 · 0 comments
Closed

show version of brave/sync in about:brave #128

diracdeltas opened this issue Jul 10, 2017 · 0 comments
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 10, 2017

so we can tell which version is being used in releases

@diracdeltas diracdeltas added this to the pyramid 2 milestone Jul 10, 2017
@diracdeltas diracdeltas self-assigned this Jul 10, 2017
diracdeltas added a commit that referenced this issue Jul 10, 2017
Needed for #128
diracdeltas added a commit to brave/browser-laptop that referenced this issue Jul 10, 2017
requires brave/sync#129
fixes brave/sync#128

Test Plan:
1. build sync library from brave/sync#129
2. open about:brave. it should show the sync version at the end.
@diracdeltas diracdeltas mentioned this issue Jul 10, 2017
4 of 8 tasks complete
@diracdeltas diracdeltas modified the milestones: pyramid 3, pyramid 2 Jul 13, 2017
diracdeltas added a commit to brave/browser-laptop that referenced this issue Jul 13, 2017
and changes versionInfo from List to Map

fixes brave/sync#128

Test Plan:
1. open about:brave. it should show the sync version.
bsclifton added a commit to brave/browser-laptop that referenced this issue Jul 15, 2017
and changes versionInfo from List to Map

fixes brave/sync#128

Test Plan:
1. open about:brave. it should show the sync version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.