Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync record resolution is losing some records #130

Closed
diracdeltas opened this issue Jul 10, 2017 · 1 comment
Closed

sync record resolution is losing some records #130

diracdeltas opened this issue Jul 10, 2017 · 1 comment
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 10, 2017

tested w/ sync 1.3.2. i created a sync group on Laptop, serg joined on Android and then added some bookmarks and 2 folders on Android. Folder 1 was missing on Laptop.

this is what browser-laptop sent in RESOLVE_SYNC_RECORDS:

[[{"action":0,"bookmark":{"isFolder":false,"parentFolderObjectId":[124,51,88,108,115,165,9,109,93,53,46,112,45,130,98,135],"site":{"creationTime":0,"customTitle":"","favicon":"","lastAccessedTime":0,"location":"https://www.amazon.com/","title":"Amazon.com: Online Shopping for Electronics, Apparel, Computers, Books, DVDs & more"}},"deviceId":[1],"objectData":"bookmark","objectId":[166,251,66,54,237,237,109,129,38,184,221,40,210,51,116,165],"syncTimestamp":1499727740281},null],[{"action":0,"bookmark":{"isFolder":true,"parentFolderObjectId":[],"site":{"creationTime":0,"customTitle":"","favicon":"","lastAccessedTime":0,"location":"","title":"Folder2"}},"deviceId":[1],"objectData":"bookmark","objectId":[41,46,116,47,5,169,20,94,223,139,95,100,239,212,57,127],"syncTimestamp":1499727756517},null],[{"action":1,"bookmark":{"isFolder":true,"parentFolderObjectId":[41,46,116,47,5,169,20,94,223,139,95,100,239,212,57,127],"site":{"creationTime":0,"customTitle":"","favicon":"","lastAccessedTime":0,"location":"","title":"Folder1"}},"deviceId":[1],"objectData":"bookmark","objectId":[124,51,88,108,115,165,9,109,93,53,46,112,45,130,98,135],"syncTimestamp":1499727756573},null]]

This is what it received on RESOLVED_SYNC_RECORDS:

 [{"action":0,"bookmark":{"isFolder":false,"parentFolderObjectId":[124,51,88,108,115,165,9,109,93,53,46,112,45,130,98,135],"site":{"creationTime":0,"customTitle":"","favicon":"","lastAccessedTime":0,"location":"https://www.amazon.com/","title":"Amazon.com: Online Shopping for Electronics, Apparel, Computers, Books, DVDs & more"}},"deviceId":[1],"objectData":"bookmark","objectId":[166,251,66,54,237,237,109,129,38,184,221,40,210,51,116,165],"syncTimestamp":1499727740281},{"action":0,"bookmark":{"isFolder":true,"parentFolderObjectId":null,"site":{"creationTime":0,"customTitle":"","favicon":"","lastAccessedTime":0,"location":"","title":"Folder2"}},"deviceId":[1],"objectData":"bookmark","objectId":[41,46,116,47,5,169,20,94,223,139,95,100,239,212,57,127],"syncTimestamp":1499727756517}]

the folder1 bookmark has gone missing

@diracdeltas diracdeltas added this to the pyramid 2 milestone Jul 10, 2017
@ayumi
Copy link
Contributor

@ayumi ayumi commented Jul 10, 2017

Looks like folder1 was sent as an Update record whereas folder2 was sent as Create, maybe that messed up the resolution.
That being said folder1 Update should probably resolve to a Create.

@ayumi ayumi self-assigned this Jul 11, 2017
ayumi added a commit that referenced this issue Jul 11, 2017
Fix #130
@ayumi ayumi closed this in #131 Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.