Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty folder is not synced after 'Sync this device' is re-enbled #134

Closed
LaurenWags opened this issue Jul 11, 2017 · 1 comment
Closed

Empty folder is not synced after 'Sync this device' is re-enbled #134

LaurenWags opened this issue Jul 11, 2017 · 1 comment
Assignees

Comments

@LaurenWags
Copy link

@LaurenWags LaurenWags commented Jul 11, 2017

Did you search for similar issues before submitting this one?
Yes

Description:
When sync is not on (i.e. 'Sync this device' is off in Preferences), if an empty folder is added, the folder is not sycned when 'Sync this device' is turned on.

Pyramid 0 is Mac Laptop
Pyramid 1 is Nexus 5

Device Details:

Install Type(ARM, x86): Arm
Device(Phone, Tablet, Phablet): Mac Laptop, Nexus5
Android Version: Nexus 5 is 5.1

Brave Version:
Android version is 1.0.24beta
Laptop version is 0.17.15

Steps to reproduce:

  1. Have laptop and Android synced successfully.
  2. On laptop go to Preferences > Sync.
  3. Toggle off 'Sync this device'.
  4. On laptop, add an empty bookmark folder.
  5. Wait a few minutes, and then toggle on 'Sync this device'.

Actual Behavior
empty folder isn't synced to Android.

Expected Behavior
empty folder should be synced.

Is this an issue in the currently released version?

Can this issue be consistently reproduced?
Yes

Extra QA steps:

Website problems only:

did you check with Brave Shields down?
did you check in Chrome for same behavior?

Screenshot if needed:

Any related issues:

@ayumi
Copy link
Contributor

@ayumi ayumi commented Jul 11, 2017

I repro'd this between 2 browser-laptop pyramids (browser-laptop 62f69f139e5e386d863be3ffba98414c95a291b1; sync v1.3.4; MacOS).

Bookmark sent; bookmark folder did not.

ayumi added a commit to brave/browser-laptop that referenced this issue Jul 11, 2017
Fix brave/sync#134

Test Plan:
1. Between two Pyramids, enable Sync and join the same profile.
2. On Pyramid 0 toggle Sync off.
3. On Pyramid 0 add a bookmark folder and bookmark, both top level items on the bookmarks toolbar.
4. On Pyramid 0 toggle Sync on.
5. Change to Pyramid 1 and wait for syncing; both folder and bookmark should sync over.
@ayumi ayumi mentioned this issue Jul 11, 2017
4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.