Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET_BOOKMARK_ORDER may receive both prevOrder and nextOrder empty #225

Closed
AlexeyBarabash opened this issue Oct 12, 2018 · 0 comments
Closed

GET_BOOKMARK_ORDER may receive both prevOrder and nextOrder empty #225

AlexeyBarabash opened this issue Oct 12, 2018 · 0 comments
Assignees
@AlexeyBarabash

Comments

@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Oct 12, 2018

GET_BOOKMARK_ORDER command may receive both prevOrder and nextOrder empty.
The simplest case is when the bookmark is added to an empty bookmarks folder. There is no way to find what are prevOrder and nextOrder because there are no any items in a folder at this time.

The obvious solution is to set result based on a parentOrder , make it parentOrder+".1" not to break the all scheme.
@AlexeyBarabash AlexeyBarabash self-assigned this Oct 12, 2018
@AlexeyBarabash AlexeyBarabash mentioned this issue Oct 12, 2018
Merged
AlexeyBarabash referenced this issue Oct 15, 2018
@AlexeyBarabash
Merge pull request #226 from brave/order_prev_next_empty
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
487bbf1 
handle situation when prev and next orders are empty; fix#225
darkdh referenced this issue Nov 20, 2018
@AlexeyBarabash @darkdh
handle situation when prev and next orders are empty; fix#225
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
750ace4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@AlexeyBarabash
You can’t perform that action at this time.