Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ability for client to avoid direct deal with base_order #227
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @bridiver comment #226 (comment)
we should handle the case where all 3 are blank (first node added) - we really have no use or need for the base order in the client and I think we should encapsulate all the logic here so the client doesn't have to know or care about how the order works, so I think we should store it in the lib and use it for this case
Add call setBaseBookmarksOrder(deviceId, platform) which client would call after eash start.
Then call getBookmarkOrder(prevOrder, nextOrder, parentOrder) will always succeed even for the case when all thre arguments are empty - this means we want to get order for very root bookmark object (folder) and return
baseBookmarksOrder+"1".