Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for client to avoid direct deal with base_order #227

Open
AlexeyBarabash opened this issue Oct 14, 2018 · 0 comments
Open

Add ability for client to avoid direct deal with base_order #227

AlexeyBarabash opened this issue Oct 14, 2018 · 0 comments

Comments

@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Oct 14, 2018

From @bridiver comment #226 (comment)
we should handle the case where all 3 are blank (first node added) - we really have no use or need for the base order in the client and I think we should encapsulate all the logic here so the client doesn't have to know or care about how the order works, so I think we should store it in the lib and use it for this case

Add call setBaseBookmarksOrder(deviceId, platform) which client would call after eash start.
Then call getBookmarkOrder(prevOrder, nextOrder, parentOrder) will always succeed even for the case when all thre arguments are empty - this means we want to get order for very root bookmark object (folder) and return baseBookmarksOrder+"1" .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.