Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS allow * #29

Closed
diracdeltas opened this issue Jan 12, 2017 · 0 comments
Closed

CORS allow * #29

diracdeltas opened this issue Jan 12, 2017 · 0 comments
Assignees
@diracdeltas
Milestone
pyramid 0

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 12, 2017

@garvankeeley reports a bug on iOS where CORS is preventing the webview from accessing the sync server, even though we whitelisted the webview origin. AFAICT it is fine for us to set CORS to * on sync*.brave.com and the S3 buckets, since we do not use cookies, HTTP auth, or SSL client certs for authentication.
@diracdeltas diracdeltas added this to the pyramid 0 milestone Jan 12, 2017
@diracdeltas diracdeltas self-assigned this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
  pyramid 0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@diracdeltas
You can’t perform that action at this time.