Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprate-limit duplicate updates to the same object #31
Assignees
Labels
Comments
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 25, 2017
and only trigger sync when important site fields are modified. fix #8415 may also fix brave/sync#31 test plan: 0. automated sync tests should pass 1. enable sync and go to https://example.com 2. bookmark it. you should see a message in the console indicating a record was sent. 3. close the page and visit it again. you should not see a message in the console. 4. unbookmark it. you should see a message in the console indicating a record was sent.
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 25, 2017
and only trigger sync when important site fields are modified. fix #8415 may also fix brave/sync#31 test plan: 0. automated sync tests should pass 1. enable sync and go to https://example.com 2. bookmark it. you should see a message in the console indicating a record was sent. 3. close the page and visit it again. you should not see a message in the console. 4. unbookmark it. you should see a message in the console indicating a record was sent.
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 25, 2017
and only trigger sync when important site fields are modified. fix #8415 may also fix brave/sync#31 test plan: 0. automated sync tests should pass 1. enable sync and go to https://example.com 2. bookmark it. you should see a message in the console indicating a record was sent. 3. close the page and visit it again. you should not see a message in the console. 4. unbookmark it. you should see a message in the console indicating a record was sent.
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 27, 2017
and only trigger sync when important site fields are modified. fix #8415 may also fix brave/sync#31 test plan: 0. automated sync tests should pass 1. enable sync and go to https://example.com 2. bookmark it. you should see a message in the console indicating a record was sent. 3. close the page and visit it again. you should not see a message in the console. 4. unbookmark it. you should see a message in the console indicating a record was sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
browser-laptop emits two appState changes every time a history entry is modified. for the purpose of sync, this should not require sending two network requests. either browser-laptop or sync client should rate-limit updates to the same object if the updates are approximately the same, by some definition.