Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show list of devices #41

Closed
diracdeltas opened this issue Jan 19, 2017 · 2 comments
Closed

show list of devices #41

diracdeltas opened this issue Jan 19, 2017 · 2 comments
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 19, 2017

brave/browser-laptop should display the list of sync devices and have a button to remove each of them

@diracdeltas diracdeltas added this to the pyramid 1 milestone Jan 19, 2017
@diracdeltas diracdeltas self-assigned this Jan 19, 2017
@ayumi
Copy link
Contributor

@ayumi ayumi commented Jan 22, 2017

  1. To show sync devices, I'm imagining a Sync library IPC endpoint which will go through Preferences and return the Device records. Can I work on that?

  2. How do you delete a device? You could add a Delete Device record, which would express "I'm trying to delete my other device" but would that prevent the deleted device from syncing records?

Or maybe it would also go thru all Records and delete all records written by the deleted device.

@diracdeltas diracdeltas removed their assignment Jan 23, 2017
@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented Jan 23, 2017

To show sync devices, I'm imagining a Sync library IPC endpoint which will go through Preferences and return the Device records. Can I work on that?

sgtm. you can use the subroutine from maybeSetDeviceId, which gets existing device IDs from Preferences.

How do you delete a device? You could add a Delete Device record, which would express "I'm trying to delete my other device" but would that prevent the deleted device from syncing records?

maybe:

  1. if deleting this device, then send a DELETE SyncRecord with objectData device ('name' can be anything)
  2. if deleting another device, create a new SyncRecord with objectData field that is DeletedDevice? Then the next time the deleted device syncs, it sees itself in DeletedDevice and does step 1.

alternatively we could just say that devices can only delete themselves or delete all devices (by deleting the user or preferences)

Or maybe it would also go thru all Records and delete all records written by the deleted device.

i think i would still expect that the device doesn't keep syncing stuff when it's on

@diracdeltas diracdeltas mentioned this issue Feb 7, 2017
@ayumi ayumi self-assigned this Apr 6, 2017
ayumi added a commit to brave/browser-laptop that referenced this issue Apr 7, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
@ayumi ayumi mentioned this issue Apr 7, 2017
3 of 4 tasks complete
ayumi added a commit to brave/browser-laptop that referenced this issue Apr 10, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
ayumi added a commit to brave/browser-laptop that referenced this issue Apr 11, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
ayumi added a commit to brave/browser-laptop that referenced this issue Apr 11, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
ayumi added a commit to brave/browser-laptop that referenced this issue Apr 11, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
bsclifton added a commit to brave/browser-laptop that referenced this issue Apr 11, 2017
Requires brave/sync#71

Fixes brave/sync#41

Test plan:
1. Start Brave and enable Sync, naming the device "Pyramid 1".
2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2".
3. Pyramid 2's device list should show both pyramids.
4. In Pyramid 1, wait a bit, 30-60s.
5. Pyramid 1's device list should also show both pyramids.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.