Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upshow list of devices #41
Comments
Or maybe it would also go thru all Records and delete all records written by the deleted device. |
sgtm. you can use the subroutine from maybeSetDeviceId, which gets existing device IDs from Preferences.
maybe:
alternatively we could just say that devices can only delete themselves or delete all devices (by deleting the user or preferences)
i think i would still expect that the device doesn't keep syncing stuff when it's on |
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
Requires brave/sync#71 Fixes brave/sync#41 Test plan: 1. Start Brave and enable Sync, naming the device "Pyramid 1". 2. `npm run start2` Brave and add it to Pyramid 1's Sync profile and name it "Pyramid 2". 3. Pyramid 2's device list should show both pyramids. 4. In Pyramid 1, wait a bit, 30-60s. 5. Pyramid 1's device list should also show both pyramids.
brave/browser-laptop should display the list of sync devices and have a button to remove each of them