Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync bookmark order from one device to another #45

Closed
ayumi opened this issue Jan 20, 2017 · 2 comments
Closed

Sync bookmark order from one device to another #45

ayumi opened this issue Jan 20, 2017 · 2 comments
Labels
enhancement
Milestone
pyramid 0

Comments

@ayumi
Copy link
Contributor

@ayumi ayumi commented Jan 20, 2017 •
edited

Right now syncing bookmarks to a new device disrupts the ordering from the original device. This is surprising.

Most users would expect that upon Syncing a new pyramid, bookmarks sync with original ordering.
@ayumi ayumi added the enhancement label Jan 20, 2017
@ayumi ayumi modified the milestones: pyramid 1, pyramid 0 Jan 20, 2017
@ayumi
Copy link
Contributor Author

@ayumi ayumi commented Jan 24, 2017

Partially implemented by 2953593 with the addition of SyncRecord.Bookmark.index
@ayumi ayumi mentioned this issue Feb 1, 2017
Merged
ayumi added a commit to brave/browser-laptop that referenced this issue Feb 1, 2017
@ayumi
Sync initial bookmarks in order
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
620cffc 
Re-introduce SyncRecord.Bookmark.index after Sites Map refactor.

Fix brave/sync#45

Auditors: @diracdeltas

Test plan:
1. Start Pyramid 0. It should have bookmarks and bookmark folders.
2. Enable Sync on Pyramid 0, and restart to complete setup.
3. Start Pyramid 1. Add it to Pyramid 0's Sync profile and restart.
4. Bookmarks should sync onto Pyramid 1 in the same order as Pyd 0.
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Feb 1, 2017

closed by brave/browser-laptop@620cffc
@diracdeltas diracdeltas closed this Feb 1, 2017
@ayumi ayumi changed the title Sync bookmark order Sync bookmark order from one device to another Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
  pyramid 0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ayumi @diracdeltas
You can’t perform that action at this time.