Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Records should be returned in upload order #53

Closed
ayumi opened this issue Feb 13, 2017 · 0 comments
Closed

Records should be returned in upload order #53

ayumi opened this issue Feb 13, 2017 · 0 comments
Labels
bug

Comments

@ayumi
Copy link
Contributor

@ayumi ayumi commented Feb 13, 2017

Currently we upload records with a prefix including the timestamp in seconds.
S3 returns keys by "UTF-8 binary order", so for example if you put record 0 ".../12340000/z/..." then record 1 ".../12340000/a/..." then record 1 would be returned first.

This impacts the initial sync, when order is important.

We could solve this by storing the timestamp at millisecond precision.

Related: #49
@ayumi ayumi added the bug label Feb 13, 2017
ayumi added a commit that referenced this issue Feb 13, 2017
@ayumi
record timestamp in ms precision
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
af88453 
Fix #53
@ayumi ayumi mentioned this issue Feb 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ayumi
You can’t perform that action at this time.