Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upinitial sync download way slow with over 9000 sync records #65
Labels
Comments
ayumi
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 5, 2017
Auditors: @diracdeltas Fix brave/sync#65 Also fixes Sync bookmarks tests for changed data-test-ids. Test plan: 1. Point Sync to prod server: In `js/constants/appConfig.js` set `isProduction = true`. 2. Start Brave and join the "forsaken" Sync group. 3. It should seem to do nothing for 10s, then lock up for ~20s, then a lot of bookmarks should be synced. (Compare with 2-3 minutes of freezing previously) (Please take care to not clear this sync profile! when you're done, just delete the userData folder.)
ayumi
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 5, 2017
Auditors: @diracdeltas Fix brave/sync#65 Also fixes Sync bookmarks tests for changed data-test-ids. Test plan: 1. Point Sync to prod server: In `js/constants/appConfig.js` set `isProduction = true`. 2. Start Brave and join the "forsaken" Sync group. 3. It should seem to do nothing for 10s, then lock up for ~20s, then a lot of bookmarks should be synced. (Compare with 2-3 minutes of freezing previously) (Please take care to not clear this sync profile! when you're done, just delete the userData folder.)
ayumi
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 5, 2017
Auditors: @diracdeltas Fix brave/sync#65 Also fixes Sync bookmarks tests for changed data-test-ids. Test plan: 1. Point Sync to prod server: In `js/constants/appConfig.js` set `isProduction = true`. 2. Start Brave and join the "forsaken" Sync group. 3. It should seem to do nothing for 10s, then lock up for ~20s, then a lot of bookmarks should be synced. (Compare with 2-3 minutes of freezing previously) (Please take care to not clear this sync profile! when you're done, just delete the userData folder.)
ayumi
added a commit
to brave/browser-laptop
that referenced
this issue
Apr 5, 2017
Auditors: @diracdeltas Fix brave/sync#65 Also fixes Sync bookmarks tests for changed data-test-ids. Test plan: 1. Point Sync to prod server: In `js/constants/appConfig.js` set `isProduction = true`. 2. Start Brave and join the "forsaken" Sync group. 3. It should seem to do nothing for 10s, then lock up for ~20s, then a lot of bookmarks should be synced. (Compare with 2-3 minutes of freezing previously) (Please take care to not clear this sync profile! when you're done, just delete the userData folder.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
our load testing sync profile "forsaken" leads to an initial download of 35+ MiB and 10,000s of records:
this issue is for 2 because locking the browser up is very unfun. we should limit the number of sync records downloaded and applied at once, so initial sync is done in incremental groups.