Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEmit brave/sync version with GET_INIT_DATA #129
Merged
Conversation
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Jul 10, 2017
requires brave/sync#129 fixes brave/sync#128 Test Plan: 1. build sync library from brave/sync#129 2. open about:brave. it should show the sync version at the end.
|
|
| nonceCounter: 0 | ||
| nonceCounter: 0, | ||
| // Sync library version, updated every brave/sync release | ||
| syncVersion: 'v1.3.3' |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedJul 10, 2017
Needed for #128