Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix record resolution of Update bookmarks with site.title #131
Conversation
|
@SergeyZhukovsky found that the bookmarks appear correct on browser-laptop when you sync to the profile; it's only messed up when testing browser-laptop and android synchronously. so the test plan may not be sufficient |
|
i can confirm that the test plan passes without running |
| }, | ||
| objectData: 'bookmark' | ||
| } | ||
| resolveToCreate(t, recordProps, recordProps, t.name) |
This comment has been minimized.
This comment has been minimized.
|
synchronous test worked |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedJul 11, 2017
•
edited
Fix #130
Test plan:
yarn distinto browser-laptop