Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record resolution of Update bookmarks with site.title #131

Merged
merged 1 commit into from Jul 11, 2017

Conversation

@ayumi
Copy link
Contributor

ayumi commented Jul 11, 2017

Fix #130

Test plan:

  1. yarn dist into browser-laptop
  2. change browser laptop appConfig to sync prod and join the sync profile from #130 on sync prod:
sulfuric operate wilfully poltergeist
balder playmate fica milt
unsettle headstrong madwoman compensatory
winteriest botcher giddying crustiest
  1. after bookmarks download, there should be a Folder2 which contains Folder1.
Fix #130
@ayumi ayumi requested a review from diracdeltas Jul 11, 2017
@ayumi ayumi self-assigned this Jul 11, 2017
@diracdeltas
Copy link
Member

diracdeltas commented Jul 11, 2017

@SergeyZhukovsky found that the bookmarks appear correct on browser-laptop when you sync to the profile; it's only messed up when testing browser-laptop and android synchronously. so the test plan may not be sufficient

@diracdeltas
Copy link
Member

diracdeltas commented Jul 11, 2017

i can confirm that the test plan passes without running yarn dist, so i think this will require synchronous testing to make sure it fixes the issue

@diracdeltas diracdeltas requested a review from SergeyZhukovsky Jul 11, 2017
},
objectData: 'bookmark'
}
resolveToCreate(t, recordProps, recordProps, t.name)

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Jul 11, 2017

Member

++ test looks good

@diracdeltas
Copy link
Member

diracdeltas commented Jul 11, 2017

synchronous test worked 👩‍🚒

Copy link
Member

SergeyZhukovsky left a comment

Looks good

@ayumi ayumi merged commit 806e4f1 into staging Jul 11, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ayumi ayumi deleted the fix/folder-title-resolution branch Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.