Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespaced SNS and SQS #173

Merged
merged 1 commit into from Oct 20, 2017
Merged

Use namespaced SNS and SQS #173

merged 1 commit into from Oct 20, 2017

Conversation

@ayumi
Copy link
Contributor

ayumi commented Oct 19, 2017 •
edited

To prevent users from mucking with each others' data.
@ayumi ayumi requested a review from SergeyZhukovsky Oct 19, 2017
@ayumi
Use namespaced SNS and SQS
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
74615f6 
To prevent users from mucking with each others' data
@ayumi ayumi force-pushed the fix/SNS_SQS_notifications branch from 3986830 to 74615f6 Oct 19, 2017
@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Oct 20, 2017

++
@SergeyZhukovsky
SergeyZhukovsky approved these changes Oct 20, 2017
View changes
Copy link
Member

SergeyZhukovsky left a comment

looks good, thanks
@ayumi ayumi merged commit 683a6ca into SNS_SQS_notifications Oct 20, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ayumi ayumi deleted the fix/SNS_SQS_notifications branch Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ayumi @SergeyZhukovsky
You can’t perform that action at this time.