Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix, Test requestUtil prefs/device; add helpers #19
+531
−183
Conversation
Auditors: @diracdeltas
| @@ -121,7 +121,7 @@ const maybeSetDeviceId = () => { | |||
| if (!requester.s3) { | |||
| throw new Error('cannot set device ID because AWS SDK is not initialized.') | |||
| } | |||
| return requester.list(proto.categories.PREFERENCES) | |||
| return requester.list(proto.categories.wS) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -53,7 +53,7 @@ const logSync = (message, logLevel = DEBUG) => { | |||
| * @returns {Object} | |||
| */ | |||
| const decrypt = (ciphertext) => { | |||
| const d = clientSerializer.byteArrayToSecretBoxRecord(ciphertext) | |||
| const d = clientSerializer.byteArrayToSecretboxRecord(ciphertext) | |||
This comment has been minimized.
This comment has been minimized.
| t.test('#put preference: device', (t) => { | ||
| t.plan(2) | ||
| const deviceId = new Uint8Array([0]) | ||
| const name = 'alpha pyramid' |
This comment has been minimized.
This comment has been minimized.
| @@ -1,7 +1,8 @@ | |||
| 'use strict' | |||
|
|
|||
| const awsSdk = require('aws-sdk') | |||
| const crc32 = require('buffer-crc32') | |||
| const crc = require('crc') | |||
| const s3Helper = require('../lib/s3Helper') | |||
|
|
|||
| // Max size of a record in bytes. Limited by s3 key size. | |||
| const MAX_RECORD_SIZE = 900 | |||
This comment has been minimized.
This comment has been minimized.
|
fixes to be done in follow ups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedDec 23, 2016
Auditors: @diracdeltas