Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to sync v1.4.3 #190

Merged
merged 1 commit into from Nov 20, 2018
Merged

update to sync v1.4.3 #190

merged 1 commit into from Nov 20, 2018

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 27, 2018

to do a new sync release:

  1. merge this into staging
  2. merge staging changes into master
  3. publish a new release to https://github.com/brave/sync/releases from master
@diracdeltas
update to sync v1.4.3
Loading status checks…
ee955a2
@diracdeltas diracdeltas mentioned this pull request Nov 20, 2018
Merged
@darkdh
Copy link
Member

darkdh commented Nov 20, 2018

can we merge this now? I will cherry-pick it to staging-to-master branch
@diracdeltas
Copy link
Member Author

diracdeltas commented Nov 20, 2018

@darkdh feel free to approve and merge
@darkdh darkdh self-requested a review Nov 20, 2018
@darkdh
darkdh approved these changes Nov 20, 2018
View changes
Copy link
Member

darkdh left a comment

++
@darkdh darkdh merged commit 3acd094 into staging Nov 20, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
darkdh added a commit that referenced this pull request Nov 20, 2018
@darkdh
Merge pull request #190 from brave/feature/v1.4.3
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
7646d30 
update to sync v1.4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@diracdeltas @darkdh
You can’t perform that action at this time.