Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve notification promise #197

Merged
merged 3 commits into from Apr 9, 2018
Merged

Resolve notification promise #197

merged 3 commits into from Apr 9, 2018

Conversation

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Apr 9, 2018

No description provided.

@SergeyZhukovsky
Resolve promise on set bucket notification configuration
Loading status checks…
02091a8
@SergeyZhukovsky
Travis fixes
Loading status checks…
bcf6cb9
@SergeyZhukovsky SergeyZhukovsky requested a review from diracdeltas Apr 9, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Apr 9, 2018

Can you remove yarn.lock since this project no longer uses Yarn? (package-lock.json does the same thing and is updated with every npm install/update.) otherwise lgtm
@SergeyZhukovsky
Removed yarn.lock as an obsolete
Loading status checks…
1098c7f
@diracdeltas
diracdeltas approved these changes Apr 9, 2018
View changes
@SergeyZhukovsky
Copy link
Member Author

SergeyZhukovsky commented Apr 9, 2018

Done!
@diracdeltas diracdeltas merged commit 22f1ece into staging Apr 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
darkdh added a commit that referenced this pull request Nov 20, 2018
@SergeyZhukovsky @darkdh
Resolve notification promise (#197)
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
badecc9 
* Resolve promise on set bucket notification configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@SergeyZhukovsky @diracdeltas
You can’t perform that action at this time.