Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Browsing is not a per site setting #198

Closed
wants to merge 1 commit into from
Closed

Conversation

@jumde
Copy link
Contributor

jumde commented Apr 9, 2018

No description provided.

@jumde jumde mentioned this pull request Apr 9, 2018
@jumde jumde requested a review from diracdeltas Apr 9, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Apr 10, 2018

@jumde Since this would break syncing of safebrowsing settings on platforms that still support it as a site setting (iOS/Android), I would prefer if we left sync as-is and just sent undefined as the safebrowsing site setting on Laptop.

@jumde
Copy link
Contributor Author

jumde commented Apr 10, 2018

Sounds good.

@jumde jumde closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.