Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter error messages from the credential server #206
Merged
Conversation
The credential server returns 200 no matter what, so errors due to invalid credentials will propagate until protobufjs thorws an error. This changes it to show 401 whenever credentials cannot be generated. Test plan: 1. npm start 2. npm run browsertest (which is currently failing) 3. in the error messages, you should see '401 unauthorized' instead of a protobuf error.
|
++ |
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedMay 14, 2018
The credential server returns 200 no matter what, so errors due to
invalid credentials will propagate until protobufjs thorws an error.
This changes it to return 401 whenever credentials cannot be generated.
Test plan:
a protobuf error.