Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dependencies, update package-lock #215

Merged
merged 3 commits into from Oct 10, 2018
Merged

Remove some dependencies, update package-lock #215

merged 3 commits into from Oct 10, 2018

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Oct 9, 2018

  • Remove NSP since this is covered by npm audit
  • Remove pry since this seems unused?

Fix #214
@diracdeltas diracdeltas requested review from darkdh and SergeyZhukovsky Oct 9, 2018
@darkdh
darkdh approved these changes Oct 9, 2018
View changes
@diracdeltas
Copy link
Member Author

diracdeltas commented Oct 9, 2018

plz don't merge until i check out the travis failures
@diracdeltas
Remove some dependencies, update package-lock
Loading status checks…
a8e8c4b 
* Remove NSP since this is covered by npm audit
* Remove pry since this seems unused?

Fix #214
@diracdeltas diracdeltas force-pushed the fix/214 branch from 9a12e7c to a8e8c4b Oct 9, 2018
diracdeltas added 2 commits Oct 9, 2018
@diracdeltas
run npm build
Loading status checks…
719144c
@diracdeltas
update aws-sdk to latest
Loading status checks…
bf1cee8
@diracdeltas
Copy link
Member Author

diracdeltas commented Oct 10, 2018

going to merge this since staging is already broken and this fixes 1 out of the 4 errors on staging
@diracdeltas diracdeltas merged commit c37337b into staging Oct 10, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the fix/214 branch Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh

@SergeyZhukovsky SergeyZhukovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@diracdeltas @darkdh
You can’t perform that action at this time.