Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda function notifications #217

Merged
merged 2 commits into from Oct 10, 2018
Merged

Lambda function notifications #217

merged 2 commits into from Oct 10, 2018

Conversation

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Oct 9, 2018 •
edited

It's corresponding that issue #216
@SergeyZhukovsky
Remove SNS topic
Loading status checks…
e5c9645
@SergeyZhukovsky
Remove unused function
Loading status checks…
5d93a90
@SergeyZhukovsky SergeyZhukovsky requested a review from diracdeltas Oct 9, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Oct 9, 2018 •
edited

both this and my last PR are failing due to https://travis-ci.org/brave/sync/builds/439281371#L731. im looking into it
@diracdeltas
diracdeltas approved these changes Oct 10, 2018
View changes
@diracdeltas diracdeltas merged commit 8e4d329 into staging Oct 10, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@diracdeltas diracdeltas deleted the lambda_function_notifications branch Oct 10, 2018
@diracdeltas diracdeltas mentioned this pull request Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@SergeyZhukovsky @diracdeltas
You can’t perform that action at this time.