Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProprogate seed info to maybeSetDeviceId #222
Merged
Conversation
|
Could you rebase? |
client/sync.js
Outdated
| @@ -20,6 +21,7 @@ var clientDeviceId = null | |||
| var clientUserId = null | |||
| var clientKeys = {} | |||
| var config = {} | |||
| var seed = null | |||
This comment has been minimized.
This comment has been minimized.
diracdeltas
Oct 10, 2018
•
Member
[minor] can you set this to undefined so https://github.com/brave/sync/pull/222/files#diff-6ce8437e6c27185736d22013ce441e15R71 is the same as before in the case where the seed hasn't been set?
|
addressed in b5fd363 |
|
lint is failing |
|
one is |
|
@darkdh you can just do |
|
yep, fixed in 0fcb89f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedOct 10, 2018
fix #221