handle situation when prev and next orders are empty; fix#225 #226
+17
−9
fixed codereview notices and CI report
- Loading branch information
| @@ -44,16 +44,18 @@ const getPrevOrderFromNextOrder = (lastNumber, order) => { | ||
| * Returns current bookmark order based on previous and next bookmark order. | ||
| * @param {String} prevOrder | ||
| * @param {String} nextOrder | ||
|
||
| * @param {String} parentOrder | ||
| * @returns {String} | ||
| */ | ||
| module.exports.getBookmarkOrder = (prevOrder, nextOrder, parentOrder) => { | ||
| let prevOrderSplit = prevOrder.split('.') | ||
| let nextOrderSplit = nextOrder.split('.') | ||
|
|
||
| if (prevOrderSplit.length === 1 && nextOrderSplit.length === 1) { | ||
| if (!parentOrder) { | ||
|
||
| throw new Error(`Invalid previous and next orders: ${prevOrderSplit}, ${nextOrderSplit} and ${parentOrder}`) | ||
| throw new Error(`Invalid previous, next and parent orders: ${prevOrderSplit}, ${nextOrderSplit} and ${parentOrder}`) | ||
| } else { | ||
| return parentOrder + '.1'; | ||
| return parentOrder + '.1' | ||
| } | ||
| } | ||
| let order = '' | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
please document parentOrder in these comments (using jsdoc)