Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to speed up polling new records #229

Merged
merged 2 commits into from Oct 17, 2018
Merged

Changes to speed up polling new records #229

merged 2 commits into from Oct 17, 2018

Conversation

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Oct 17, 2018

closes #228
@SergeyZhukovsky
Changes to speed up polling new records
Loading status checks…
263a961
@SergeyZhukovsky
Corresponding travis changes
Loading status checks…
df1195c
@diracdeltas
Copy link
Member

diracdeltas commented Oct 17, 2018

it would be good to have an automated test for this
@SergeyZhukovsky
Copy link
Member Author

SergeyZhukovsky commented Oct 17, 2018 •
edited

Yep we have an issue for that #220. Do you have any idea how it could be covered? Well I can create a simple notification on a test bucket and call the API to poll it, but it will not really cover the scenario with Amazon servers peak times sometimes.
@SergeyZhukovsky
Copy link
Member Author

SergeyZhukovsky commented Oct 17, 2018

I propose we prioritize #220 and make the tests in a separate PR instead of blocking the fix of existing functionality.
@diracdeltas
Copy link
Member

diracdeltas commented Oct 17, 2018

yeah, i think it would be good for just having basic SQS functionality tests to make sure that updates don't break anything (since i don't know how to test this manually right now). probably no need to test for performance right now.
@diracdeltas
diracdeltas approved these changes Oct 17, 2018
View changes
@SergeyZhukovsky SergeyZhukovsky merged commit ff9c7f3 into staging Oct 17, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas

@AlexeyBarabash AlexeyBarabash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Polling bookmarks records is slow
2 participants
@SergeyZhukovsky @diracdeltas
You can’t perform that action at this time.