Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAuto refresh AWS credentials #23
Merged
Conversation
client/requestUtil.js
Outdated
| @@ -1,27 +1,103 @@ | |||
| 'use strict' | |||
|
|
|||
| const MAX_RETRIES = 1 | |||
| const NONCE_COUNTER = 0 | |||
This comment has been minimized.
This comment has been minimized.
diracdeltas
Dec 29, 2016
Member
this should be imported from client/config.js so it doesn't need to be edited in more than one place when it changes
client/sync.js
Outdated
| credentialsBytes: null, // TODO: Start with previous session's credentials | ||
| keys: clientKeys, | ||
| serializer: clientSerializer, | ||
| syncServerUrl: config.serverUrl |
This comment has been minimized.
This comment has been minimized.
client/sync.js
Outdated
| }) | ||
| } | ||
| const decrypt = cryptoUtil.Decrypt(clientSerializer, clientKeys.secretboxKey) | ||
| const encrypt = cryptoUtil.Encrypt(clientSerializer, clientKeys.secretboxKey, conf.nonceCounter) |
This comment has been minimized.
This comment has been minimized.
diracdeltas
Dec 29, 2016
Member
these functions need to be initialized after clientSerializer is initialized, otherwise clientSerializer is null.
ayumi
force-pushed the
feature/auto-refresh-aws-credentials
branch
from
de7984a
to
7182210
ayumi
force-pushed the
feature/auto-refresh-aws-credentials
branch
from
7182210
to
f420d1f
|
@diracdeltas thx, I made some changes based on your feedbacks. could you take another look? |
|
thanks, lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedDec 29, 2016