Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMerge staging into master #249
Merged
Conversation
Generate package-lock.json by 1. modifying package.json in browser-launcher to have merge dep "^1.2.1" 2. delete merge folder in node_modules 3. npm install 4. make sure we have modified packge-lock.json 5. rm entire node_modules 6. do npm install and make sure we install merge version >= 1.2.1 7. npm audit should have no errors now
|
FYI if you are going to do a sync release, there needs to be a version bump: #190 |
|
@yan do you know why travis is stuck in infinite |
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "name": "@brave/sync-client", | |||
| "version": "0.1.0", | |||
This comment has been minimized.
This comment has been minimized.
diracdeltas
Nov 20, 2018
Member
i don't remember if there are any clients currently using this NPM package (as opposed to downloading sync bundle from github releases). if so i can publish an update.
|
@darkdh i remember seeing that; we don't really use flow in a useful way so we can just exclude that from travis |
darkdh
added a commit
that referenced
this pull request
Nov 20, 2018
Also exclude flow in travis #249 (comment)
darkdh
added a commit
that referenced
this pull request
Nov 20, 2018
Also exclude flow in travis #249 (comment)
|
There are two tests failed |
|
@darkdh probably needs new AWS credentials; see https://github.com/brave/sync/pull/210/files @evq or someone in #devops can help you get the new credentials |
darkdh
added a commit
that referenced
this pull request
Nov 20, 2018
Also update access_key_id_production and secret_access_key_production And exclude flow in travis #249 (comment)
Also update access_key_id_production and secret_access_key_production And exclude flow in travis #249 (comment)
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedNov 20, 2018
•
edited
branch generated by