Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uglifyjs2 #harmony #25

Merged
merged 1 commit into from Dec 30, 2016
Merged

Add uglifyjs2 #harmony #25

merged 1 commit into from Dec 30, 2016

Conversation

@ayumi
Copy link
Contributor

ayumi commented Dec 30, 2016

Fix #16

  • yarn build bundle.js is now 1.35 MB (was 3.03 MB)
  • browser tests include uglifyjs but without --mangle

Notes:

  • source map (og -> browserify -> uglify) was too much effort
  • uglifyjs --compress not used; it takes more time, might be weird and saves only 20K
@ayumi ayumi requested a review from diracdeltas Dec 30, 2016
@ayumi ayumi force-pushed the feature/uglify branch 3 times, most recently from 6ce5b7e to 703d8d2 Dec 30, 2016
"build": "yarn upgrade && browserify client/sync.js -o bundles/bundle.js",
"browsertest": "yarn start-test; browserify test/client/*.js test/*.js | tape-run; yarn stop-test",
"browsertest-client": "yarn start-test; browserify test/client/*.js | tape-run --browser chrome; yarn stop-test",
"build": "yarn upgrade && browserify client/sync.js | uglifyjs - --mangle > bundles/bundle.js",

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Dec 30, 2016

Member

i think we should leave out mangling since it doesn't seem to save much. that would make the tests run over the same thing that is shipping

This comment has been minimized.

Copy link
@ayumi

ayumi Dec 30, 2016

Author Contributor

good idea

@ayumi ayumi force-pushed the feature/uglify branch from 703d8d2 to 7d331cf Dec 30, 2016
@ayumi ayumi merged commit 9686a60 into staging Dec 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ayumi ayumi deleted the feature/uglify branch Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.