Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplock `merge`@1.2.1 pkg in package-lock.json #259
Merged
Conversation
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
lock `merge`@1.2.1 pkg in package-lock.json
cezaraugusto
added a commit
that referenced
this pull request
Dec 11, 2018
lock `merge`@1.2.1 pkg in package-lock.json
|
i don't think substack is maintaining this package. @darkdh fixed this issue previously in #245 and we will have to fix this again every time someone updates the deps. @cezaraugusto unless substack decides to update his package, i think the fix is either to fork browser-launcher, use a different test framework, or add a postinstall script to fix the merge dep every time |
|
pinged substack and the package has been updated! substack/browser-launcher#42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cezaraugusto commentedDec 11, 2018
this is a temp fix while substack/browser-launcher#43 isn't merged