Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upREADME fixes #268
Closed
README fixes #268
Conversation
|
@diracdeltas do you have any video why would travis fail on unit tests on a simple readme file change? |
| Results appear in both the browser inspector and your terminal. | ||
|
|
||
| To run tests in Node, just do `npm test`. | ||
|
|
||
| To do a basic client/server integration test against the production server, run | ||
| `npm run client` and navigate to `http://localhost:8000/`). The page | ||
| `npm run client` and navigate to `http://localhost:4000/`). The page |
This comment has been minimized.
This comment has been minimized.
diracdeltas
Dec 28, 2018
Member
This shouldn't change since run client runs python -m SimpleHTTPServer which runs on 8000 by default.
|
not sure why travis is failing but it seems unrelated to this change since it's also happening on #267 |
|
Re-created PR #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
samartnik commentedDec 27, 2018
These are just suggestions. From my experience I was't able to run command
npm browsertestand get any info fromlocalhost:8000