Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf.js to 6.4.5; use proto static code #27

Closed
wants to merge 1 commit into from

Conversation

@ayumi
Copy link
Contributor

ayumi commented Jan 8, 2017

Fix #6

  • With static code proto classes you can't use reflection e.g. SyncRecord.lookup('Site'). This is minor beause you'd just do SyncRecord.Site.
  • oneof attributes have issues, notably SyncRecord .objectData is stuck as "bookmark". As a workaround I made a helper: serializer.getSyncRecordObjectData()
@ayumi ayumi closed this Jan 8, 2017
@ayumi ayumi deleted the feature/proto-6.4 branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.