Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch recommendations for Brave Sync Improvements #275

Merged
merged 3 commits into from Mar 5, 2019

Conversation

@hspencer77
Copy link
Contributor

hspencer77 commented Jan 9, 2019

Contains architecture recommendations for Brave Sync.

Associated task: https://github.com/brave/devops/projects/13#card-16355778

@diracdeltas
Copy link
Member

diracdeltas commented Jan 18, 2019

thanks @hspencer77!

  1. please exclude architecture/.DS_Store
  2. would this work as a wiki document instead? that would make it easier to edit/update. https://github.com/brave/sync/wiki
@diracdeltas diracdeltas self-requested a review Jan 18, 2019
@hspencer77
Copy link
Contributor Author

hspencer77 commented Feb 5, 2019

@diracdeltas sorry for the delay in my response. Yes, I can move it to the wiki. The diagrams would still need a place to live (can be under the architecture folder), but everything else can be put in the wiki.

Harold Spencer Jr added 2 commits Feb 5, 2019
@diracdeltas diracdeltas merged commit 27e63ed into brave:staging Mar 5, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.