Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate deps with `npm audit fix` #282
Merged
Conversation
|
++ But we need the same fix in staging branch. We use diff branches for production and for staging. |
|
travis is failing as well! |
|
please do not submit PR directly into master You will have to submit PR to staging first and then after it is merged you use merge commit to open PR against master. |
|
@darkdh OK great - updated |
|
++ |
bsclifton
added a commit
that referenced
this pull request
Feb 19, 2019
Update deps with `npm audit fix`
bsclifton
added a commit
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedFeb 15, 2019
Resolves this warning (found via
npm audit):