Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBrave syncer update #305
Merged
Brave syncer update #305
Conversation
|
|
|
Looks good @darkdh |
|
++ |
…d missing 'parentFolderObjectId':[]
Create + Update + Update of an existing object should resolve to a separate Update
…ate'
…ull. Can be squashed
…st to 'sequential Updates should become no op if the merged result equals to existingObject'
Merge by id action (staging)
|
can I get a re-review of this PR? |
Merged
|
looks good |
darkdh
added a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedApr 18, 2019
•
edited
This is necessary for brave/brave-core#2010
Old code must deploy this new deps before above PR landed or it will get exception when. This change extends the protobuf definition but it won't affect the old code functionalityget-existing-objectson old code devices