Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge keeps alone CREATE and DELETE #315

Closed

Conversation

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented May 13, 2019

We met the situation when [CREATE, UPDATE] were merged to [CREATE], which was then ignored because local object had been existed.
This PR makes CREATE and DELETE records stays alone to prevent such ignoring. So only UPDATE records of the same object id are merged.

STR for brave-core brave-syncer branch:

  1. DeviceA: create folderA in bookmarks
  2. DeviceA: create bookmarks of brave://bookmarks, brave://sync, brave://inspect, all in Bookmarks Bar folder
  3. DeviceA: enable sync and copy code words
  4. DeviceB: join sync chain with words from pt.3
  5. DeviceB: As soon as bookmarks from DeviceA appear , move 3 bookmarks into folderA
  6. Actual on DeviceA: bookmark will not be moved
    Expected on DeviceA: bookmarks should be moved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sync - All platforms
  
Awaiting triage
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.