Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upgetBookmarkOrder improve #328
Merged
+163
−83
Conversation
|
also see comments in |
|
this PR should contain only two commits, fixing |
|
++ |
AlexeyBarabash
added a commit
that referenced
this pull request
Aug 7, 2019
getBookmarkOrder improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AlexeyBarabash commentedJul 30, 2019
getBookmarkOrder('2.5.6.3', '2.5.7.8.2')gave
'2.5.6.3.1'With this PR it will give
'2.5.6.4'. It will save a digit in order string during bookmark manipulations in some cases.This PR reflects the change brave/brave-core@1649f45 for brave-core .