Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate separate queues for preferences records #331
Merged
Conversation
|
Marked as draft because does not have updated tests and delete queues code does not removes queues for prefs. |
|
Pushed fix for error found while preparing brave-core corresponding PR. |
AlexeyBarabash
force-pushed the
sync_prefs_over_sqs
branch
3 times, most recently
from
f4ac1d9
to
cbc6564
| @@ -196,7 +197,7 @@ RequestUtil.prototype.list = function (category, startAt, maxRecords, nextContin | |||
| } | |||
| // We poll from SQS | |||
| let notificationParams = { | |||
| QueueUrl: `${this.SQSUrl}`, | |||
| QueueUrl: `${this.SQSUrlByCat[category]}`, | |||
This comment has been minimized.
This comment has been minimized.
SergeyZhukovsky
Aug 23, 2019
Member
I think we should add a check in that place does this.SQSUrlByCat contains a category item or at least if it's size is not 0. And put that info in the log to easy find if something is wrong.
This comment has been minimized.
This comment has been minimized.
|
++ |
AlexeyBarabash
added a commit
that referenced
this pull request
Aug 27, 2019
Create separate queues for preferences records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AlexeyBarabash commentedAug 16, 2019
•
edited
Create queues per device per categories.