Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability (remove coverage task) #335

Closed
wants to merge 1 commit into from
Closed

Fix vulnerability (remove coverage task) #335

wants to merge 1 commit into from

Conversation

@bsclifton
Copy link
Member

bsclifton commented Sep 25, 2019 •
edited

This resolves vulnerability with handlebars by removing the coverage task and dependency
@bsclifton bsclifton requested a review from jumde Sep 25, 2019
@bsclifton bsclifton self-assigned this Sep 25, 2019
@bsclifton
Remove `coverage` task (and istanbul dep)
Verified
This commit was signed with a verified signature.
bsclifton Brian Clifton
GPG key ID: 50ED18CA5C4C0F73 Learn about signing commits
Loading status checks…
2325918 
This resolves vulnerability with handlebars.
@bsclifton bsclifton force-pushed the npm-audit-deps-fix branch from 97bee91 to 2325918 Sep 25, 2019
@jumde jumde requested a review from darkdh Sep 25, 2019
@bsclifton bsclifton changed the title Fix vulnerability (npm audit fix) Fix vulnerability (remove coverage task) Sep 25, 2019
@diracdeltas
Copy link
Member

diracdeltas commented Sep 25, 2019

dupe of #336 ?
@bsclifton
Copy link
Member Author

bsclifton commented Sep 25, 2019

@diracdeltas this is for master; #336 is for staging actually
@bsclifton bsclifton reopened this Sep 25, 2019
@bsclifton
Copy link
Member Author

bsclifton commented Sep 25, 2019

Closing as coverage is needed for CI
@bsclifton bsclifton closed this Sep 25, 2019
@diracdeltas
Copy link
Member

diracdeltas commented Sep 25, 2019

@bsclifton sorry my bad - didn't see that they were for different branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumde jumde

@darkdh darkdh

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bsclifton @diracdeltas
You can’t perform that action at this time.