Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make istanbul optional. (STAGING) #336

Merged
merged 1 commit into from Sep 25, 2019
Merged

Make istanbul optional. (STAGING) #336

merged 1 commit into from Sep 25, 2019

Conversation

@bsclifton
Copy link
Member

bsclifton commented Sep 25, 2019

This resolves vulnerability with handlebars by removing the coverage task and dependency
@bsclifton bsclifton requested review from jumde and darkdh Sep 25, 2019
@bsclifton bsclifton self-assigned this Sep 25, 2019
@diracdeltas
Copy link
Member

diracdeltas commented Sep 25, 2019

We use coverage in CI to report test coverage.
@diracdeltas
diracdeltas requested changes Sep 25, 2019
View changes
Copy link
Member

diracdeltas left a comment

coverage is used for CI
@diracdeltas diracdeltas mentioned this pull request Sep 25, 2019
Closed
@bsclifton
Make istanbul optional.
Verified
This commit was signed with a verified signature.
bsclifton Brian Clifton
GPG key ID: 50ED18CA5C4C0F73 Learn about signing commits
Loading status checks…
fd56807 
(It only gets downloaded when `npm run coverage` is ran)

Fixes #334
@bsclifton bsclifton force-pushed the npm-audit-deps-fix-staging branch from d9f833f to fd56807 Sep 25, 2019
@bsclifton bsclifton changed the title Fix vulnerability (remove coverage task) Make istanbul optional. (STAGING) Sep 25, 2019
@bsclifton
Copy link
Member Author

bsclifton commented Sep 25, 2019

@diracdeltas updated with different solution; we did the same for crypto with the js2doc dep
@diracdeltas
diracdeltas approved these changes Sep 25, 2019
View changes
@bsclifton bsclifton merged commit ec46c17 into staging Sep 25, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the npm-audit-deps-fix-staging branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas

@jumde jumde

@darkdh darkdh

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bsclifton @diracdeltas
You can’t perform that action at this time.