Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument dau by way of redis hyperloglog #342

Merged
merged 8 commits into from Oct 9, 2019
Merged

instrument dau by way of redis hyperloglog #342

merged 8 commits into from Oct 9, 2019

Conversation

@evq
Copy link
Member

evq commented Oct 3, 2019 •
edited by darkdh

fix #343
evq added 2 commits Oct 3, 2019
@evq
instrument dau by way of redis hyperloglog
Loading status checks…
38553b6
@evq
fix lint
Loading status checks…
3f88f80
@maikelmclauflin
maikelmclauflin reviewed Oct 3, 2019
View changes
@evq
update credential ttl to 24 hours
Loading status checks…
dc0dc1a
@maikelmclauflin
lookup platform info from ua and incorporate into hll
Loading status checks…
ba3098f
@maikelmclauflin
added family check to ua. formatted as browser version / os version
Loading status checks…
3c98e10
@maikelmclauflin
added test and moved parsing to own util
Loading status checks…
122b1d1
@maikelmclauflin
distilled check down to platform with known keywords
Loading status checks…
2a3479a
@maikelmclauflin
changed method to be more descriptive
Loading status checks…
977f47b
@evq
evq reviewed Oct 9, 2019
View changes
Copy link
Member Author

evq left a comment •
edited

LGTM, local testing looks good:

root@aec054d6728d:/data# redis-cli
127.0.0.1:6379> keys *
1) "sync-dau-2019-10-09-other"
127.0.0.1:6379> keys *
1) "sync-dau-2019-10-09-linux"
2) "sync-dau-2019-10-09-other"
@maikelmclauflin maikelmclauflin self-requested a review Oct 9, 2019
@maikelmclauflin
maikelmclauflin approved these changes Oct 9, 2019
View changes
@evq evq merged commit 231e868 into staging Oct 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@evq evq deleted the dau branch Oct 9, 2019
evq added a commit that referenced this pull request Oct 10, 2019
@evq
Merge pull request #342 from brave/dau
84ef7a1 
instrument dau by way of redis hyperloglog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maikelmclauflin maikelmclauflin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Better DAU calculation
2 participants
@evq @maikelmclauflin
You can’t perform that action at this time.