Use public interface to get signing seed length

[dchest]

No description provided.

[ayumi]

Thank you for the patch :)
I saw the tests failed in Travis, so I ran them locally and they passed.

@diracdeltas could you have a look?

[diracdeltas]

they also passed locally for me

…

On Sat, Jan 14, 2017 at 22:17 ａｙｕｍｉ ｙｕ ***@***.***> wrote: @ayumi <https://github.com/ayumi> requested your review on: brave/sync#35 <#35> Use public interface to get signing seed length. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhjFjX5mkn6O9m21zWs6qK06V9R22jmks5rSUlogaJpZM4LjmIM> .

[diracdeltas]

i've restarted the Travis build 3 times and each time it failed with:

# client RequestUtil
# constructor
Connecting to http://localhost:4000
not ok 30 Error: Credential server response 500
  ---
    operator: error
    expected: |-
      undefined
    actual: |-
      [Error: Credential server response 500]
    at: Test.assert [as _assert] (http://localhost:40495/bundle.js:47:28326)
    stack: |-
      Error: Credential server response 500
          at window.fetch.then.response (http://localhost:40495/bundle.js:52:20779)
  ...

so it doesn't seem to be an intermittent fail. i have no idea how this change could lead to that error. :/

[diracdeltas]

Somehow, #36 passes even though it is the exact same change :/. I am going to close this PR in favor of that. 🔮 👻

[ayumi]

@diracdeltas We use travis encrypted env vars to do the AWS tests, which for security only work when collaborators initiate the build.

[diracdeltas]

@ayumi o i c

i assume the merged branches will pass Travis since merge commits are done by collaborators, but is there a way to fix it so that outside contributor PR's don't always show up as failing?