Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide compaction complete/update callback #355

Merged
merged 3 commits into from Nov 2, 2019
Merged

Conversation

@darkdh
Copy link
Member

darkdh commented Oct 29, 2019

This PR also prevents initiating new compaction process when there exists a compaction process running for a long time
also fix #351

@darkdh darkdh self-assigned this Oct 29, 2019
@darkdh darkdh force-pushed the compaction-callback branch from b03f8fa to 712383b Oct 29, 2019
@darkdh darkdh mentioned this pull request Oct 29, 2019
8 of 32 tasks complete
Copy link
Member

SergeyZhukovsky left a comment

++

Copy link
Contributor

AlexeyBarabash left a comment

++

@darkdh darkdh dismissed stale reviews from AlexeyBarabash and SergeyZhukovsky via a59fab7 Oct 30, 2019
@darkdh darkdh changed the title Provide compaction complete callback Provide compaction complete/update callback Oct 30, 2019
@darkdh
Copy link
Member Author

darkdh commented Oct 30, 2019

will go to the same route of resolving new updates, comparing timestamp will be done in #353

@darkdh darkdh force-pushed the compaction-callback branch from a59fab7 to b22e529 Oct 30, 2019
…ply missing remote records
@darkdh darkdh force-pushed the compaction-callback branch from b22e529 to 25cdf65 Oct 30, 2019
@darkdh darkdh merged commit 0950e75 into staging Nov 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@darkdh darkdh deleted the compaction-callback branch Nov 2, 2019
darkdh added a commit that referenced this pull request Nov 2, 2019
Provide compaction complete/update callback
darkdh added a commit that referenced this pull request Nov 5, 2019
Merge pull request #355 from brave/compaction-callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.