Skip to content

/ sync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `npm-force-resolutions` dependency to help resolve npm audit vulnerabilities #375

Merged
merged 1 commit into from Mar 18, 2020
Merged

Introduce `npm-force-resolutions` dependency to help resolve npm audit vulnerabilities #375

merged 1 commit into from Mar 18, 2020
+150 −28

Conversation

@bsclifton
Copy link
Member

bsclifton commented Mar 18, 2020 •
edited

Helps to fix brave/brave-browser#8722
@bsclifton bsclifton requested a review from diracdeltas Mar 18, 2020
@bsclifton bsclifton self-assigned this Mar 18, 2020
@bsclifton bsclifton mentioned this pull request Mar 18, 2020
Closed
8 of 32 tasks complete
@bsclifton
Introduce `npm-force-resolutions` dependency to help resolve npm audi…
Loading status checks…
fac6066 
…t vulnerabilities

Helps to fix brave/brave-browser#8722
@bsclifton bsclifton force-pushed the bsc-fix-npm branch from 372fe7d to fac6066 Mar 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
@AlexeyBarabash
AlexeyBarabash approved these changes Mar 18, 2020
View changes
@bsclifton bsclifton merged commit f4b71ba into master Mar 18, 2020
3 checks passed
3 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bsclifton bsclifton deleted the bsc-fix-npm branch Mar 18, 2020
bsclifton added a commit to brave/brave-core that referenced this pull request Mar 18, 2020
@bsclifton
Updated sync dep after brave/sync#375 was merged
Loading status checks…
fa4b7b5
@AlexeyBarabash AlexeyBarabash mentioned this pull request Mar 18, 2020
Closed
bsclifton added a commit that referenced this pull request Mar 19, 2020
@bsclifton
Revert "Merge pull request #375 from brave/bsc-fix-npm"
Loading status checks…
feec5d8 
This reverts commit f4b71ba, reversing
changes made to 4428f60.
@bsclifton bsclifton mentioned this pull request Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash

@diracdeltas diracdeltas

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bsclifton @AlexeyBarabash
You can’t perform that action at this time.